Accessibility Support for Browserstack app automate sessions by nishath-bs · Pull Request #14069 · webdriverio/webdriverio

nishath-bs · 2025-01-13T16:45:41Z

Proposed changes

Accessibility Support for Browserstack app automate sessions

v8 changes for the same feature done here

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #14034

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann

Please rebase your branch on top of current main

packages/wdio-browserstack-service/src/constants.ts

packages/wdio-browserstack-service/src/util.ts

nishath-bs · 2025-01-13T21:05:13Z

@christian-bromann Already raised separate PR for the same functionality in v8 as well. So, could you please merge these if the changes look good?

christian-bromann

LGTM 👍

packages/wdio-browserstack-service/src/accessibility-handler.ts

…sent

nishath-bs · 2025-01-20T05:41:02Z

@christian-bromann Can we merge this?

christian-bromann · 2025-01-20T17:55:13Z

Can we merge this?

There is still an unresolved comment: #14069 (comment)

pkg-pr-new · 2025-01-20T17:56:15Z

Open in Stackblitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14069

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14069

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14069

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14069

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14069

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14069

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14069

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14069

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14069

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14069

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14069

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14069

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14069

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14069

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14069

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14069

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14069

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14069

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14069

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14069

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14069

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14069

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14069

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14069

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14069

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14069

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14069

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14069

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14069

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14069

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14069

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14069

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14069

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14069

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14069

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14069

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14069

commit: 4802268

packages/wdio-browserstack-service/src/accessibility-handler.ts

christian-bromann · 2025-01-20T23:14:07Z

There seems to be an error in the unit tests:

Error: Failed to load url got (resolved id: got) in D:/a/webdriverio/webdriverio/packages/wdio-browserstack-service/tests/app-accessibility-handler.test.ts. Does the file exist?

nishath-bs · 2025-01-21T13:41:45Z

There seems to be an error in the unit tests:

Error: Failed to load url got (resolved id: got) in D:/a/webdriverio/webdriverio/packages/wdio-browserstack-service/tests/app-accessibility-handler.test.ts. Does the file exist?

@christian-bromann We have fixed the UT failures. Can you please check and merge?

nishath-bs changed the title ~~App a11y scan support~~ [WIP] App a11y scan support Jan 13, 2025

christian-bromann requested changes Jan 13, 2025

View reviewed changes

packages/wdio-browserstack-service/src/constants.ts Outdated Show resolved Hide resolved

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

nishath-bs and others added 18 commits January 14, 2025 00:00

changes for before function in accessibility handler

336915a

changes for beforetest function in accessibility handler

bae2edc

changes for beforescenario function in accessibility handler

37ba039

changes for command wrapper function in accessibility handler

81c75ef

changes for constants

03075e9

changes for funnelInstrumentation

bf7dd7d

v9 changes for utils file

d2edb0f

v9 changes for accessibility handle test

2138bcc

v9 changes for app accessibility handle test

e249541

v9 changes for util test

ad032f8

comment changes

b6e3e92

got install

2b4e314

got imported

2f2708b

fix the got issue

75e9a03

changes for got function

4fc2b7c

changes for pollapi function

1588758

pollApi fix

1c0be79

eslint fix and review fixes

216d5d5

nishath-bs force-pushed the app_a11y_scan_support branch from e9d8d6f to 216d5d5 Compare January 13, 2025 20:15

removed try catch

a5e9d75

nishath-bs changed the title ~~[WIP] App a11y scan support~~ App a11y scan support Jan 13, 2025

nishath-bs requested a review from christian-bromann January 13, 2025 20:47

response json parsing fix added

5ffbae4

nishath-bs changed the title ~~App a11y scan support~~ Accessibility Support for Browserstack app automate sessions Jan 14, 2025

Merge branch 'main' into app_a11y_scan_support

a42fa2d

christian-bromann approved these changes Jan 17, 2025

View reviewed changes

packages/wdio-browserstack-service/src/accessibility-handler.ts Show resolved Hide resolved

Update packages/wdio-browserstack-service/src/accessibility-handler.ts

b903910

christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Jan 17, 2025

added try catch for overwrite command as some commands may not be pre…

38f6701

…sent

christian-bromann approved these changes Jan 20, 2025

View reviewed changes

packages/wdio-browserstack-service/src/accessibility-handler.ts Show resolved Hide resolved

Merge branch 'main' into app_a11y_scan_support

a6928af

removed got import

4802268

christian-bromann merged commit 163d834 into webdriverio:main Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Accessibility Support for Browserstack app automate sessions#14069

Accessibility Support for Browserstack app automate sessions#14069
christian-bromann merged 25 commits intowebdriverio:mainfrom
nishath-bs:app_a11y_scan_support

nishath-bs commented Jan 13, 2025 •

edited

Loading

Uh oh!

christian-bromann left a comment

Uh oh!

Uh oh!

Uh oh!

nishath-bs commented Jan 13, 2025

Uh oh!

christian-bromann left a comment

Uh oh!

Uh oh!

nishath-bs commented Jan 20, 2025

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

pkg-pr-new bot commented Jan 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

nishath-bs commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nishath-bs commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nishath-bs commented Jan 13, 2025

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nishath-bs commented Jan 20, 2025

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

pkg-pr-new bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

nishath-bs commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nishath-bs commented Jan 13, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 20, 2025 •

edited

Loading