fix(webdriver): use undici for requests in Node.js#13852
Merged
christian-bromann merged 5 commits intomainfrom Nov 26, 2024
Merged
fix(webdriver): use undici for requests in Node.js#13852christian-bromann merged 5 commits intomainfrom
christian-bromann merged 5 commits intomainfrom
Conversation
13 tasks
Member
|
Hi @christian-bromann could you explain a little bit about why we need another tool to retry? I'd think that we could simply have a solution that catches errors and in case of a timeout, puts it in a queue to retry? |
Member
Author
|
@erwinheitzman introducing undici is not to fix anything about the retry mechanism. It fixes two regressions we introduced in v9:
The package is very lightweight so I don't think it has any impact on the user. |
ebe8280 to
4cc7302
Compare
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/browser-runner
@wdio/appium-service
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is another attempt to fix the request timeout in
webdriverby falling back toundicifor making requests in Node.js. This time we will change the interface of theWebdriverRequestclass and provide a Node.js version and a cross platform version using native fetch.This PR introduces the same approach to deliver to different environments, e.g. browser, Node.js, CJS, as Puppeteer does it.
fixes #13778
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers