fix(webdriverio): use AbortSignal.timeout() instead of an AbortController by christian-bromann · Pull Request #13783 · webdriverio/webdriverio

christian-bromann · 2024-10-21T03:31:24Z

Proposed changes

use AbortSignal.timeout(timeout) instead of initiating an AbortController.

fixes #13778

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

@mykola-mokhnach mind checking if this resolves the issue?

Reviewers: @webdriverio/project-committers

…ller

pkg-pr-new · 2024-10-21T03:33:27Z

Open in Stackblitz

eslint-plugin-wdio

pnpm add https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@13783

@wdio/allure-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@13783

@wdio/appium-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@13783

@wdio/browserstack-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@13783

@wdio/browser-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@13783

@wdio/cli

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@13783

@wdio/concise-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@13783

@wdio/config

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@13783

@wdio/cucumber-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@13783

@wdio/firefox-profile-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@13783

@wdio/dot-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@13783

@wdio/jasmine-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@13783

@wdio/globals

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@13783

@wdio/junit-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@13783

@wdio/json-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@13783

@wdio/lighthouse-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@13783

@wdio/local-runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@13783

@wdio/logger

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@13783

@wdio/mocha-framework

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@13783

@wdio/protocols

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@13783

@wdio/repl

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@13783

@wdio/reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@13783

@wdio/runner

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@13783

@wdio/shared-store-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@13783

@wdio/sauce-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@13783

@wdio/smoke-test-cjs-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@13783

@wdio/smoke-test-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@13783

@wdio/spec-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@13783

@wdio/smoke-test-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@13783

@wdio/static-server-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@13783

@wdio/sumologic-reporter

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@13783

@wdio/types

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@13783

@wdio/utils

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@13783

@wdio/webdriver-mock-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@13783

webdriver

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriver@13783

webdriverio

pnpm add https://pkg.pr.new/webdriverio/webdriverio@13783

@wdio/testingbot-service

pnpm add https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@13783

commit: 53533c4

mykola-mokhnach · 2024-10-21T06:38:15Z

Thanks @christian-bromann

According to the attached SO article the proposed solution does not actually change the current (unexpected) fetch behaviour. E.g. it works for lower timeouts, but is ignored for greater values. I assume it makes sense to use the dispatcher approach instead:

import { Agent } from "undici";

await fetch("https://example.com", {
  dispatcher: new Agent({ connectTimeout: xxx })
});

christian-bromann · 2024-10-21T15:47:12Z

@mykola-mokhnach dispatcher is not available in native fetch and only is being used in undici.

mykola-mokhnach · 2024-10-21T18:19:41Z

the original error I pasted is coming from undici.
Perhaps, we could have both options there to make it more error proof?

christian-bromann · 2024-10-22T01:13:37Z

the original error I pasted is coming from undici.

This is because the Node.js implementation for fetch uses undici. However the goal to use fetch is to be able to use a version that is compatible with running it in the browser and in Node.js. We try to avoid on Node.js specific implmentation and try to use cross platform interfaces wherever possible.

Perhaps, we could have both options there to make it more error proof?

Can you verify if this change maybe fixes the problem. You can test it by adding the following capability to your project:

pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriverio@13783

mykola-mokhnach · 2024-10-22T21:46:44Z

the original error I pasted is coming from undici.

This is because the Node.js implementation for fetch uses undici. However the goal to use fetch is to be able to use a version that is compatible with running it in the browser and in Node.js. We try to avoid on Node.js specific implmentation and try to use cross platform interfaces wherever possible.

Perhaps, we could have both options there to make it more error proof?

Can you verify if this change maybe fixes the problem. You can test it by adding the following capability to your project:
pnpm add https://pkg.pr.new/webdriverio/webdriverio/webdriverio@13783

Unfortunately it did not work with my local tests, the request still times out. Perhaps I do something wrong 🤷

mykola-mokhnach · 2024-10-22T22:00:10Z

I have just added the change to the CI, maybe it would perform better there...

christian-bromann · 2024-10-23T00:03:25Z

This doesn't seem like to solve the issue, let me get back to the drawing board.

christian-bromann · 2024-10-24T19:27:30Z

@mykola-mokhnach unfortunately this seems to be an issue with Node.js native fetch implementation. I commented on an issue they have opened for it. In the meantime the best approach would be to use an alternative request library and maybe switch to undici as a fallback for mobile sessions? Wdyt?

christian-bromann · 2024-11-05T08:55:26Z

Closing in favor of #13852

* fix(webdriver): use undici for requests in Node.js * apply changes from #13783 * conditional environment * fix tests * fix interop

christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 21, 2024

fix(webdriverio): use AbortSignal.timeout() instead of an AbortContro…

53533c4

…ller

christian-bromann force-pushed the cb/fix-timeout branch from f32cf3b to 53533c4 Compare October 21, 2024 03:32

erwinheitzman approved these changes Oct 21, 2024

View reviewed changes

christian-bromann mentioned this pull request Oct 24, 2024

fetch fails with internal error after 5 minutes nodejs/node#46375

Closed

christian-bromann closed this Nov 5, 2024

christian-bromann deleted the cb/fix-timeout branch November 5, 2024 08:55

christian-bromann added a commit that referenced this pull request Nov 5, 2024

apply changes from #13783

ebe8280

christian-bromann added a commit that referenced this pull request Nov 26, 2024

apply changes from #13783

3dafae4

christian-bromann added a commit that referenced this pull request Nov 26, 2024

fix(webdriver): use undici for requests in Node.js (#13852)

5218796

* fix(webdriver): use undici for requests in Node.js * apply changes from #13783 * conditional environment * fix tests * fix interop

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(webdriverio): use AbortSignal.timeout() instead of an AbortController#13783

fix(webdriverio): use AbortSignal.timeout() instead of an AbortController#13783
christian-bromann wants to merge 1 commit intomainfrom
cb/fix-timeout

christian-bromann commented Oct 21, 2024 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 21, 2024 •

edited

Loading

Uh oh!

mykola-mokhnach commented Oct 21, 2024

Uh oh!

christian-bromann commented Oct 21, 2024

Uh oh!

mykola-mokhnach commented Oct 21, 2024

Uh oh!

christian-bromann commented Oct 22, 2024

Uh oh!

mykola-mokhnach commented Oct 22, 2024

Uh oh!

mykola-mokhnach commented Oct 22, 2024

Uh oh!

christian-bromann commented Oct 23, 2024

Uh oh!

christian-bromann commented Oct 24, 2024

Uh oh!

christian-bromann commented Nov 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

christian-bromann commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

pkg-pr-new bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mykola-mokhnach commented Oct 21, 2024

Uh oh!

christian-bromann commented Oct 21, 2024

Uh oh!

mykola-mokhnach commented Oct 21, 2024

Uh oh!

christian-bromann commented Oct 22, 2024

Uh oh!

mykola-mokhnach commented Oct 22, 2024

Uh oh!

mykola-mokhnach commented Oct 22, 2024

Uh oh!

christian-bromann commented Oct 23, 2024

Uh oh!

christian-bromann commented Oct 24, 2024

Uh oh!

christian-bromann commented Nov 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

christian-bromann commented Oct 21, 2024 •

edited

Loading

pkg-pr-new bot commented Oct 21, 2024 •

edited

Loading