Skip to content

enable edge for devTools env detector#12439

Merged
christian-bromann merged 1 commit intowebdriverio:v8from
lacell75:backport12432
Mar 9, 2024
Merged

enable edge for devTools env detector#12439
christian-bromann merged 1 commit intowebdriverio:v8from
lacell75:backport12432

Conversation

@lacell75
Copy link
Copy Markdown
Contributor

@lacell75 lacell75 commented Mar 6, 2024 •
edited
Loading

Proposed changes

polish backport #12432 to v8

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@lacell75 lacell75 changed the title fix devtools Env detect enable edge for devTools env detector Mar 6, 2024
@erwinheitzman
Copy link
Copy Markdown
Member

erwinheitzman commented Mar 6, 2024

I have replied to your changes in #12432

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Mar 6, 2024

I have replied to your changes in #12432

@erwinheitzman I can't see a reply in that issue 🤔

@erwinheitzman
Copy link
Copy Markdown
Member

erwinheitzman commented Mar 9, 2024

Oh my bad I think I meant to post this in a different PR 👀 I had not seen this code yet

erwinheitzman
erwinheitzman approved these changes Mar 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 9, 2024
@christian-bromann christian-bromann merged commit d161729 into webdriverio:v8 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lacell75 @erwinheitzman @christian-bromann