Skip to content

(feat): enable chromium protocol for edge#12432

Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom
lacell75:enableChromiumForEdge
Mar 5, 2024
Merged

(feat): enable chromium protocol for edge#12432
christian-bromann merged 4 commits intowebdriverio:mainfrom
lacell75:enableChromiumForEdge

Conversation

@lacell75
Copy link
Copy Markdown
Contributor

@lacell75 lacell75 commented Mar 5, 2024

Proposed changes

Resolves features request #12385

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 5, 2024
@christian-bromann christian-bromann merged commit f2b0cc4 into webdriverio:main Mar 5, 2024
@wdio-bot
Copy link
Copy Markdown
Contributor

wdio-bot commented Mar 5, 2024

Hey lacell75 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Mar 5, 2024 •
edited
Loading

@lacell75 do you think we can backport this to v8? nevermind, I was able to cherry-pick the squash commit.

christian-bromann pushed a commit that referenced this pull request Mar 5, 2024
@lacell75 @christian-bromann
(feat): enable chromium protocol for edge (#12432)
bbbbece 
* (feat): enable chromium protocol for edge

* update doc

* fix test

* fix mistake
@lacell75 lacell75 mentioned this pull request Mar 6, 2024
Merged
11 tasks
@lacell75
Copy link
Copy Markdown
Contributor Author

lacell75 commented Mar 6, 2024 •
edited
Loading

nevermind, I was able to cherry-pick the squash commit.

nice! I just made one more adaptation to v8

07souravkunda pushed a commit to amaanbs/webdriverio that referenced this pull request Mar 7, 2024
@lacell75 @07souravkunda
(feat): enable chromium protocol for edge (webdriverio#12432)
6aef263 
* (feat): enable chromium protocol for edge

* update doc

* fix test

* fix mistake
This was referenced Mar 7, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $50 💸 PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lacell75 @wdio-bot @christian-bromann