fix: avoid script Array.from() for older browsers#11717
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Nov 23, 2023
Merged
fix: avoid script Array.from() for older browsers#11717christian-bromann merged 1 commit intowebdriverio:mainfrom
Array.from() for older browsers#11717christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
0626380 to
3eb4acf
Compare
Contributor
Author
|
Going to run the tests again (one failure) but seems to happen on |
Internet Explorer (all versions) never supported `Array.from()` See: https://caniuse.com/mdn-javascript_builtins_array_from
christian-bromann
approved these changes
Nov 23, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot 👍
3eb4acf to
fd3d405
Compare
Member
Yes, we have some flakes in our e2e tests in working on improving on it. |
Contributor
Author
|
Thanks @christian-bromann was just running the checks again for my green tick 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd missed another ES2015 feature in #11712 that causes element
isDisplayed()errors in older browsersThis PR fixes #11716 which shows more info:
Array.from()errors in older browsers viaisElementDisplayed()#11716Proposed changes
Due to missing
Array.from()support in Internet Explorer, we should changeelement.childNodesloops:Types of changes
Checklist
Further comments
I've used
npm linkon this branch against our test suite and Internet Explorer 11 now works fully 🙌https://app.saucelabs.com/tests/337440d31bba4b86bef79ad74120cd75?auth=df173806cff971e450b9c09008348705
Reviewers: @webdriverio/project-committers