fix: avoid script syntax to support IE11 again (#11711)#11712
Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom Nov 22, 2023
Merged
fix: avoid script syntax to support IE11 again (#11711)#11712christian-bromann merged 3 commits intowebdriverio:mainfrom
christian-bromann merged 3 commits intowebdriverio:mainfrom
Conversation
…driverio#11711) IE11 only supports `.contains()` from HTMLElement (not Document) type elements
christian-bromann
approved these changes
Nov 22, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Awesome changeset 👍
Member
Yeah, it seems like we start to have a need for a more sophisticated build system (e.g. via Vite) that can help us package different projects and files in them. That seems like a bigger effort though. Feel free to raise an issue about it and I can add some comments on where a better build system can help us. |
1 task
Contributor
Author
Done ✅ |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Attempts to fix #11711 so WebdriverIO v8 works with IE11
Avoids the following in browser scripts:
=>const { that } = this.contains()toHTMLElementtypeFor 3) I've changed
documenttodocument.bodywhich supports.contains()in IE11Types of changes
Checklist
Further comments
It might help to lower TypeScript
"target": "es2022"for ./packages/webdriverio/src/scripts in futureArrow functions can be downleveled automatically
Reviewers: @webdriverio/project-committers