deleted BidiHandler and browser commands from Element type#11679
deleted BidiHandler and browser commands from Element type#11679christian-bromann merged 2 commits intomainfrom
Conversation
|
Oh it seems there are a lot of references... Are we convinced we'd like to exclude browser commands from element? @christian-bromann |
Yes, I don't expect anyone to use it because it would throw an error at runtime. The build shows one error caused by: webdriverio/packages/webdriverio/src/utils/index.ts Lines 201 to 203 in 6ef2bd3 I suggest the following change: - if (!(scope as WebdriverIO.Element).elementId) {
+ if (!('elementId' in scope)) {
return scope.execute(selector as any, referenceId)
}Note: if a core package fails to compile you usually get a ton of other TS errors as well since it won't be able to access types of that core package. |
Yes there was just one place where it should be changed. Thank you for the explanation. It worth to know! |
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks a lot!
…ypes webdriverio/webdriverio#11679 removed browser commands from WebdriverIO.Element
as a part of the pr #11636