Skip to content

(webdriverio): remove type support for browser commands on element in…#11636

Merged
christian-bromann merged 1 commit intomainfrom
cb/remove-browser-command-types-from-element
Nov 9, 2023
Merged

(webdriverio): remove type support for browser commands on element in…#11636
christian-bromann merged 1 commit intomainfrom
cb/remove-browser-command-types-from-element

Conversation

@christian-bromann
Copy link
Member

Proposed changes

fixes #11582

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 9, 2023
@christian-bromann christian-bromann merged commit fccead9 into main Nov 9, 2023
@christian-bromann christian-bromann deleted the cb/remove-browser-command-types-from-element branch November 9, 2023 23:54
@udarrr
Copy link
Member

udarrr commented Nov 15, 2023

Hi @christian-bromann, it seems deletions in 506 line not enough, I believe in line 289 where is Element type with the same structure Omit<BrowserCommandsType, keyof ElementCommandsType> should be corrected also.

@christian-bromann
Copy link
Member Author

Good catch! Mind raising a PR?

@udarrr
Copy link
Member

udarrr commented Nov 15, 2023

Good catch! Mind raising a PR?

Yes sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Webdriverio.Element has types issues

2 participants