(doc): migrate to eta from ejs#11102
Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom Sep 6, 2023
Merged
Conversation
Member
|
@tamil777selvan thanks for taking a stab at this. I am not sure if mustache is a good choice. It hasn't seen any release for more than 2 years and seems like abandoned to me. Any chance we can use |
Member
Author
|
Hi @christian-bromann, I followed your advice and started using ETA. Could you please take a look at it whenever you get a chance? Thank you! |
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Can we also remove the postinstall:vulnerabilities command and the file connected to it?
The rest looks good to me, great job!
scripts/templates/template.eta
Outdated
Comment on lines
+19
to
+21
| <% /* This protocol command is embedded in the following convenient method<%= it.alternativeCommands.length > 1 ? 's' : '' %>: <% for (const altCommand of it.alternativeCommands) { %>[<%= altCommand.split('/').pop() %>](/docs/api/<%= altCommand %>)<% } %>. It is recommended to use <%= it.alternativeCommands.length > 1 ? 'these commands' : 'this command' %> instead. */ %> | ||
|
|
||
| This protocol command is embedded in the following convenient method<%= it.alternativeCommands.length > 1 ? 's' : '' %>: <%= it.alternativeCommands.map((command) => `[${command.split('/').pop()}}](/docs/api/${command})`).join(', ') %>. It is recommended to use <%= it.alternativeCommands.length > 1 ? 'these commands' : 'this command' %> instead. |
Member
There was a problem hiding this comment.
Suggested change
| <% /* This protocol command is embedded in the following convenient method<%= it.alternativeCommands.length > 1 ? 's' : '' %>: <% for (const altCommand of it.alternativeCommands) { %>[<%= altCommand.split('/').pop() %>](/docs/api/<%= altCommand %>)<% } %>. It is recommended to use <%= it.alternativeCommands.length > 1 ? 'these commands' : 'this command' %> instead. */ %> | |
| This protocol command is embedded in the following convenient method<%= it.alternativeCommands.length > 1 ? 's' : '' %>: <%= it.alternativeCommands.map((command) => `[${command.split('/').pop()}}](/docs/api/${command})`).join(', ') %>. It is recommended to use <%= it.alternativeCommands.length > 1 ? 'these commands' : 'this command' %> instead. | |
| This protocol command is embedded in the following convenient method<%= it.alternativeCommands.length > 1 ? 's' : '' %>: <%= it.alternativeCommands.map((command) => `[\`${command.split('/').pop()}\`](/docs/api/${command})`).join(', ') %>. It is recommended to use <%= it.alternativeCommands.length > 1 ? 'these commands' : 'this command' %> instead. |
Member
Author
I have updated it @christian-bromann, please have a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix - #6640
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers