[v8] Console logs and cucumber hooks support #11098
[v8] Console logs and cucumber hooks support #11098christian-bromann merged 21 commits intowebdriverio:mainfrom
Conversation
This reverts commit 5d55469.
| if (config.layout) { | ||
| layout = layouts.layout(config.layout.type, config.layout) | ||
| } | ||
| return BSTestOpsLog4JSAppender(layout, config.timezoneOffset) |
There was a problem hiding this comment.
Can we not call this "log4js"? It suggest you are using this package which you aren't.
There was a problem hiding this comment.
We are not using log4js in our code, we are just defining an appender that users can use to configure in their log4js configuration. So we don't need the log4js package for this
| export const log4jsAppender = { configure } | ||
| export const BStackTestOpsLogger = logReportingAPI |
There was a problem hiding this comment.
Why are these exported? Are these suppose to be used by users? If so we should provide docs for them right?
There was a problem hiding this comment.
Yes @christian-bromann these are supposed to be used by user if they want support for log4js and winston-logger. Will create a separate PR for docs, as also need to make other doc changes for observability as well
Co-authored-by: Christian Bromann <git@bromann.dev>
Co-authored-by: Christian Bromann <git@bromann.dev>
|
@christian-bromann Have resolved comments. Please check. Also there are merge conflicts in package files due to the package added. Everytime I resolve it, the conflict appears again when a new webdriverio version releases. So will resolve it later when the PR is ready to merge. Or if you have any ideas to avoid conflicts altogether, lmk |
|
@sriteja777 can you update the branch and resolve the conflicts? |
|
@christian-bromann as I said in this comment, the merge conflicts are appearing every time a new webdriverio version is released due to change in package files. Everytime I resolve it, the conflict appears again when a new webdriverio version releases. So if changes look good to you, I can resolve the conflicts so that you can merge |
|
@christian-bromann Have made the requested changes. Please re-review |
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Note: I can functionally test these features. I mentioned it before that it would be best to move this service into the BrowserStack org
|
Once rebased I am happy to merge. |
# Conflicts: # package-lock.json # packages/wdio-browserstack-service/package.json
|
@christian-bromann Have resolved conflicts. Make sure you merge this PR before merging other PRs or release, as it will create the conflicts again. |
Proposed changes
Related v7 PR: #10961
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers