Skip to content

[v7] Console logs and cucumber hooks support#10961

Merged
christian-bromann merged 11 commits intowebdriverio:v7from
sriteja777:OB-1787_console_logs_v7
Sep 21, 2023
Merged

[v7] Console logs and cucumber hooks support#10961
christian-bromann merged 11 commits intowebdriverio:v7from
sriteja777:OB-1787_console_logs_v7

Conversation

@sriteja777
Copy link
Contributor

@sriteja777 sriteja777 commented Aug 17, 2023 •
edited
Loading

Proposed changes

  1. Add console logs support for observability
  2. Add cucumber hooks support for observability

Related v8 PR: #11098

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777 sriteja777 marked this pull request as draft August 17, 2023 12:32
@christian-bromann
Copy link
Member

christian-bromann commented Aug 22, 2023

@sriteja777 let me know when this PR is ready for review.

@sriteja777 sriteja777 marked this pull request as ready for review September 5, 2023 05:16
@sriteja777
Copy link
Contributor Author

sriteja777 commented Sep 5, 2023

@christian-bromann The PR is ready for review. Please review in your free time

@sriteja777 sriteja777 mentioned this pull request Sep 5, 2023
Merged
8 tasks
@sourav-kundu
Copy link
Contributor

sourav-kundu commented Sep 20, 2023

@christian-bromann These changes are the same as v8 changes.
Could you please review and release v7 as well?

christian-bromann
christian-bromann approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

The build is currently broken for the v7 branch, to fix it we need to downgrade the saucelabs package the way we have it in the main branch. If you can make this PR for the v7 branch I am happy to release v7 today.

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Sep 21, 2023
@christian-bromann christian-bromann merged commit 366298d into webdriverio:v7 Sep 21, 2023
@sriteja777
Copy link
Contributor Author

sriteja777 commented Sep 22, 2023

Thanks @christian-bromann, will make the changes. Can you please point to where exactly we need to downgrade the saucelabs package, and it would be helpful if there is any corresponding PR to main that I can refer?

@christian-bromann
Copy link
Member

christian-bromann commented Sep 22, 2023

@sriteja777 please see 0a84c5e

@sriteja777
Copy link
Contributor Author

sriteja777 commented Sep 22, 2023

@christian-bromann Have made the PR. Can you please check once?

@sriteja777 sriteja777 mentioned this pull request Sep 22, 2023
Merged
8 tasks
@sourav-kundu
Copy link
Contributor

sourav-kundu commented Sep 29, 2023

@christian-bromann Can we release a v7 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

+1 more reviewer

@sauravdas1997 sauravdas1997 sauravdas1997 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sriteja777 @christian-bromann @sourav-kundu @sauravdas1997