[browserstack-service] Sending skipped test details for beforeEach, beforeAll and afterEach hooks in mocha#10258
Conversation
added observability and browserstack check
|
@christian-bromann Please review this PR |
christian-bromann
left a comment
There was a problem hiding this comment.
Can we update the branch and see if the test pass? If so I am happy to merge.
| let parentTitle = test.parent | ||
| // Sometimes parent will be an object instead of a string | ||
| if (typeof test.parent === 'object') { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Can we resolve the type issue?
There was a problem hiding this comment.
Actually, we are getting the test object from the context of the test that is passed to the service (test.ctx.test.parent) in some places. And this object doesn't match with Framework.Test type which has parent has string, but in the context object, the parent can be an object. Also we don't have any exported types to type for this context.
Currently removed the ts-ignore and casted it to any. Let me know if you have any better solution
|
@christian-bromann the tests have passed. Please merge if it looks good to you. |
Proposed changes
Related v7 PR #10259
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers