Skip to content

[browserstack-service] [v7] Sending skipped test details for beforeEach, beforeAll and afterEach hooks in mocha#10259

Merged
christian-bromann merged 4 commits intowebdriverio:v7from
sriteja777:suite_reporter_v7
Apr 26, 2023
Merged

[browserstack-service] [v7] Sending skipped test details for beforeEach, beforeAll and afterEach hooks in mocha#10259
christian-bromann merged 4 commits intowebdriverio:v7from
sriteja777:suite_reporter_v7

Conversation

@sriteja777
Copy link
Contributor

Proposed changes

  • Sending test details as skipped whenever hook fails along with hook failure details

Related v8 PR: #10258
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777
Copy link
Contributor Author

@christian-bromann Please review this v7 PR

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 26, 2023
@christian-bromann christian-bromann merged commit cab85f0 into webdriverio:v7 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants