Skip to content

fix: continue work on responsive styling issues#1983

Merged
SoonIter merged 2 commits intoweb-infra-dev:mainfrom
JounQin:fix/styling
Mar 20, 2025
Merged

fix: continue work on responsive styling issues#1983
SoonIter merged 2 commits intoweb-infra-dev:mainfrom
JounQin:fix/styling

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented Mar 20, 2025

Summary

Related Issue

continue #1961

Before:

image image image image image

After:

image image image image image

cc @Timeless0911 @SoonIter @chenjiahan

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit b35399a
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67dbd78bb90aa80008fabd25
😎 Deploy Preview https://deploy-preview-1983--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit b35399a
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67dbd78b4c2f2800085232d8
😎 Deploy Preview https://deploy-preview-1983--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Copy Markdown
Member

hey, could you investigate sidebar: false is not work in frontmatter?

---
sidebar: false
---

@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Mar 20, 2025

image

@SoonIter Is this expected for mobile? Sidebar is unavailable, then the users can't change pages via sidebar then.

But on desktop

image

@Timeless0911
Copy link
Copy Markdown
Contributor

@JounQin Hi, check your X messages, DM me if possible. 🤙

@SoonIter
Copy link
Copy Markdown
Member

---
sidebar: false
---

before

image

after

it does not work after #1928

image

@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Mar 20, 2025

image

Is this really as expected? Then how would the user change pages in that page? Only previous and next?

@SoonIter
Copy link
Copy Markdown
Member

Is this really as expected? Then how would the user change pages in that page? Only previous and next?

Feel sorry that no test for this feature, but it did run in https://lynxjs.org/blog/index.html

I'll merge this pr first, could you help us regress this issue?

@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Mar 20, 2025

image

How about this? Only hide the aside button?

image

@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Mar 20, 2025

Feel sorry that no test for this feature, but it did run in lynxjs.org/blog/index.html

OK, understand, I'll change as that's expected then.


@SoonIter Done!

@SoonIter SoonIter merged commit d2fdcc1 into web-infra-dev:main Mar 20, 2025
11 checks passed
@JounQin JounQin deleted the fix/styling branch March 20, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants