Skip to content

fix: rework sidebar menu responsive issues#1928

Merged
SoonIter merged 2 commits intoweb-infra-dev:mainfrom
JounQin:fix/responsive
Mar 10, 2025
Merged

fix: rework sidebar menu responsive issues#1928
SoonIter merged 2 commits intoweb-infra-dev:mainfrom
JounQin:fix/responsive

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented Mar 10, 2025

Summary

Related Issue

close #1540

related #1914

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

I aslo added --rp-content-padding-x and --rp-content-padding-y css variables so that the aside can be responsive their changes.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 10, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 805eab5
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67ceb92700a0300008788629
😎 Deploy Preview https://deploy-preview-1928--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 10, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 805eab5
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67ceb9275e698c0008ea07c0
😎 Deploy Preview https://deploy-preview-1928--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Copy Markdown
Member

:D thanks for your fix, could you take a look at the 3 problem in #1929?

@SoonIter
Copy link
Copy Markdown
Member

Because this issue has some impact, I have decided to revert it first in #1930 and add it back later.

@JounQin JounQin changed the title fix: do not overflow content on small screen fix: rework sidebar menu responsive issues Mar 10, 2025
@JounQin JounQin force-pushed the fix/responsive branch 2 times, most recently from 488140d to de00f5c Compare March 10, 2025 08:51
@JounQin JounQin marked this pull request as draft March 10, 2025 09:06
@JounQin JounQin marked this pull request as ready for review March 10, 2025 09:14
@SoonIter SoonIter enabled auto-merge (squash) March 10, 2025 11:41
@SoonIter SoonIter merged commit e3d6ec5 into web-infra-dev:main Mar 10, 2025
12 checks passed
@SoonIter
Copy link
Copy Markdown
Member

thanks ❤~

@JounQin JounQin deleted the fix/responsive branch March 10, 2025 11:45
JounQin added a commit to JounQin/rspress that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: outline does not display when window width >= 960 && < 1280

2 participants