Skip to content

feat(copyRspackPlugin): align transform api with webpack plugin#9714

Merged
hardfist merged 7 commits intomainfrom
fix-8957
Mar 18, 2025
Merged

feat(copyRspackPlugin): align transform api with webpack plugin#9714
hardfist merged 7 commits intomainfrom
fix-8957

Conversation

@fireairforce
Copy link
Contributor

@fireairforce fireairforce commented Mar 18, 2025

Summary

closes: #8957

Api align need something more to support:

  • transform api align with webpack
  • copyRspackPlugin support cache feature
    • Rspack compilation support get_cache() function

I will support cache feature after compilation support compilation.get_cache() function, so this pr will not execute it.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 1796d2c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d99093f77cf500081b6227

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 18, 2025
@fireairforce fireairforce force-pushed the fix-8957 branch 4 times, most recently from 97b5cf2 to d924542 Compare March 18, 2025 11:02
@fireairforce fireairforce marked this pull request as ready for review March 18, 2025 11:04
@hardfist
Copy link
Contributor

hardfist commented Mar 18, 2025

cache is tricky and not compatible with rspack's current persistent cache, so I think we can not support cache now, can you also add params validation logic so unnecessary param type is not passed to napi options directly

@fireairforce fireairforce force-pushed the fix-8957 branch 2 times, most recently from da04ec8 to cd9b285 Compare March 18, 2025 11:27
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #9714 will not alter performance

Comparing fix-8957 (1796d2c) with main (9e9f198)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@fireairforce
Copy link
Contributor Author

cache is tricky and not compatible with rspack's current persistent cache, so I think we can not support cache now, can you also add params validation logic so unnecessary param type is not passed to napi options directly

For the reason we don't support caches config now, i just remove the config now to avoid the user to passed a useless config to napi, if we support in the feature, i will add it back and update the document, i think this is more reasonable.

@hardfist hardfist merged commit dae7542 into main Mar 18, 2025
31 checks passed
@hardfist hardfist deleted the fix-8957 branch March 18, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API mismatch between CopyRspackPlugin transform and CopyWebpackPlugin transform

2 participants