You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cache is tricky and not compatible with rspack's current persistent cache, so I think we can not support cache now, can you also add params validation logic so unnecessary param type is not passed to napi options directly
A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳! Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.
cache is tricky and not compatible with rspack's current persistent cache, so I think we can not support cache now, can you also add params validation logic so unnecessary param type is not passed to napi options directly
For the reason we don't support caches config now, i just remove the config now to avoid the user to passed a useless config to napi, if we support in the feature, i will add it back and update the document, i think this is more reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes: #8957
Api align need something more to support:
get_cache()functionI will support cache feature after
compilationsupportcompilation.get_cache()function, so this pr will not execute it.Checklist