Skip to content

feat: render runtime template with dojang#9444

Merged
GiveMe-A-Name merged 1 commit intomainfrom
feat/runtime-template-with_dojang2
Feb 26, 2025
Merged

feat: render runtime template with dojang#9444
GiveMe-A-Name merged 1 commit intomainfrom
feat/runtime-template-with_dojang2

Conversation

@GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Feb 25, 2025 •
edited
Loading

Summary

Use dojang to render runtime modules, related to #5316

More detail summary see: #9079

  • render create_script with dojang.
  • render create_script_url with dojang.
  • render define_property_getters with dojang
  • render ensure_chunk with dojang

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft February 25, 2025 02:50
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Feb 25, 2025
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8f82ece
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bd387e2d30960008993732

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9444 will not alter performance

Comparing feat/runtime-template-with_dojang2 (8f82ece) with main (7df06cf)

Summary

✅ 7 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name force-pushed the feat/runtime-template-with_dojang2 branch from 36b7537 to 8f82ece Compare February 25, 2025 03:26
@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review February 25, 2025 07:12
@GiveMe-A-Name GiveMe-A-Name requested review from LingyuCoder and removed request for LingyuCoder February 25, 2025 07:13
@GiveMe-A-Name GiveMe-A-Name merged commit d6958b9 into main Feb 26, 2025
31 checks passed
@GiveMe-A-Name GiveMe-A-Name deleted the feat/runtime-template-with_dojang2 branch February 26, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GiveMe-A-Name @LingyuCoder