feat: integrate rspack_dojang for enhanced template rendering#9079
Merged
GiveMe-A-Name merged 1 commit intomainfrom Jan 22, 2025
Merged
feat: integrate rspack_dojang for enhanced template rendering#9079GiveMe-A-Name merged 1 commit intomainfrom
GiveMe-A-Name merged 1 commit intomainfrom
Conversation
- Added rspack_dojang as a workspace dependency in rspack_core. - Introduced new template functions in RuntimeTemplate for better rendering capabilities. - Replaced static async module JavaScript with dynamic EJS templates for improved flexibility. - Enhanced AsyncRuntimeModule to utilize the new template rendering system.
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9079 will not alter performanceComparing 🎉 Hooray!
|
GiveMe-A-Name
commented
Jan 22, 2025
LingyuCoder
reviewed
Jan 22, 2025
LingyuCoder
approved these changes
Jan 22, 2025
2 tasks
This was referenced Feb 20, 2025
This was referenced Feb 28, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use dojang to render runtime modules, related to #5316
Use dojang because it supports custom function, and we can use the same code in template to generate different result by inject functions according to output.environment, and also html plugin is using it so the package size will not increase.
Inject runtime globals as parameters by default.
Dojang only support string literal so array of strings need to be joined with ,.
relate to rstackjs/rspack-dojang#3
for example, the on chunk loaded runtime module can be rendered by template blow:
Fork from #7764
Checklist