Skip to content

feat: using dojang to render runtime_template#9422

Merged
LingyuCoder merged 5 commits intomainfrom
feat/runtime-template-with_dojang
Feb 25, 2025
Merged

feat: using dojang to render runtime_template#9422
LingyuCoder merged 5 commits intomainfrom
feat/runtime-template-with_dojang

Conversation

@GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Feb 21, 2025 •
edited
Loading

Summary

Use dojang to render runtime modules, related to #5316

More detail summary see: #9079

  • render auto_public_path with dojang.
  • render compat_get_default_export with dojang.
  • render create_fake_namespace_object with dojang

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft February 21, 2025 03:06
@netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 39ee80e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bc18a4cac48b0008f8bda0

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9422 will not alter performance

Comparing feat/runtime-template-with_dojang (39ee80e) with main (e8b77c4)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name force-pushed the feat/runtime-template-with_dojang branch from a3a6205 to b9c74f6 Compare February 24, 2025 04:09
@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review February 24, 2025 06:31
@LingyuCoder LingyuCoder merged commit 7df06cf into main Feb 25, 2025
27 checks passed
@LingyuCoder LingyuCoder deleted the feat/runtime-template-with_dojang branch February 25, 2025 03:15
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GiveMe-A-Name @LingyuCoder