Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
ahabhgk
previously approved these changes
Feb 18, 2025
CodSpeed Performance ReportMerging #9355 will not alter performanceComparing 🎉 Hooray!
|
JSerFeng
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #9354
This pull request includes multiple changes to the
rspack-test-toolspackage and a small fix in theChunkGraphimplementation. The changes primarily focus on adding new test cases and configurations for runtime chunk hash handling and making a small logic correction in theChunkGraphcode.Test Cases and Configurations:
index.jsfiles for directoriesa,b, andmain. These tests ensure that the runtime chunk is correctly bundled and verified. [1] [2] [3]file.jsmodule with different exports for the test cases to verify the runtime chunk behavior. [1] [2]rspack.config.jsconfiguration file to define entry points, output settings, and optimization options for the runtime chunk tests.test.config.jsfile to find the main bundle and ensure it is not run multiple times during the tests.Code Fix:
ChunkGraphimplementation by correcting the condition to check forfull_hashinruntime_module.Checklist