Skip to content

fix: runtime chunk check full hash#9355

Merged
LingyuCoder merged 2 commits intomainfrom
fix/runtime-chunk-fullhash
Feb 18, 2025
Merged

fix: runtime chunk check full hash#9355
LingyuCoder merged 2 commits intomainfrom
fix/runtime-chunk-fullhash

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Feb 18, 2025

Summary

fix #9354

This pull request includes multiple changes to the rspack-test-tools package and a small fix in the ChunkGraph implementation. The changes primarily focus on adding new test cases and configurations for runtime chunk hash handling and making a small logic correction in the ChunkGraph code.

Test Cases and Configurations:

  • Added new test cases for runtime chunk hash handling in index.js files for directories a, b, and main. These tests ensure that the runtime chunk is correctly bundled and verified. [1] [2] [3]
  • Created a file.js module with different exports for the test cases to verify the runtime chunk behavior. [1] [2]
  • Added a rspack.config.js configuration file to define entry points, output settings, and optimization options for the runtime chunk tests.
  • Added a test.config.js file to find the main bundle and ensure it is not run multiple times during the tests.

Code Fix:

  • Fixed a logic error in the ChunkGraph implementation by correcting the condition to check for full_hash in runtime_module.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 18, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 18, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e73b508
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b4461f21e73b0008326cb1

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 18, 2025
@LingyuCoder LingyuCoder marked this pull request as ready for review February 18, 2025 08:12
@LingyuCoder LingyuCoder requested a review from ahabhgk February 18, 2025 08:12
ahabhgk
ahabhgk previously approved these changes Feb 18, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #9355 will not alter performance

Comparing fix/runtime-chunk-fullhash (e73b508) with main (73688e8)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder enabled auto-merge (squash) February 18, 2025 08:58
@LingyuCoder LingyuCoder merged commit 4df2004 into main Feb 18, 2025
29 checks passed
@LingyuCoder LingyuCoder deleted the fix/runtime-chunk-fullhash branch February 18, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The runtime chunk is decided to be a fullhash chunk even no fullhash in it

3 participants