Skip to content

chore: upgrade swc_core from 66 to 67#14135

Merged
hardfist merged 6 commits into
mainfrom
cursor/upgrade-swc-crates-905d
May 26, 2026
Merged

chore: upgrade swc_core from 66 to 67#14135
hardfist merged 6 commits into
mainfrom
cursor/upgrade-swc-crates-905d

Conversation

@hardfist

@hardfist hardfist commented May 24, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Upgrade the workspace SWC dependency pins to the latest compatible published versions and refresh the corresponding Cargo lockfile entries.

swc_error_reporters 24.0.0 and swc_plugin_runner 28.0.0 were tested, but remain pinned to the current compatible versions because the latest swc_core 66.0.5 still uses swc_common 21, while those newer crates use swc_common 22.

This also updates the generated workspace SWC core version so CI builds do not dirty crates/rspack_workspace/src/generated.rs.

Related links

N/A

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Validation

  • cargo codegen
  • pnpm run build:binding:dev && git diff --quiet -- . ":(exclude).cargo/config.toml"
  • cargo test -q -p rspack_javascript_compiler -p rspack_loader_swc -p rspack_plugin_swc_js_minimizer --locked
  • pnpm run lint:rs
Open in Web Open in Cursor 

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copilot AI review requested due to automatic review settings May 24, 2026 02:22
Copilot AI reviewed May 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the workspace-pinned SWC Rust crates to newer patch releases and updates the Cargo lockfile accordingly, keeping the repo’s Rust toolchain dependencies current.

Changes:

  • Bump workspace-pinned swc, swc_core, and swc_ecma_minifier to newer patch versions.
  • Refresh Cargo.lock to reflect the updated SWC dependency graph and checksums.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updates workspace dependency pins for key SWC crates.
Cargo.lock Updates resolved SWC package versions/checksums (and related transitive entries).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq

codspeed-hq Bot commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 37 untouched benchmarks
⏩ 25 skipped benchmarks1

Comparing cursor/upgrade-swc-crates-905d (1a7885a) with main (e66c3db)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 1a7885a to fix(rslib): align isolated dts diagnostics (#14143) by Timeless0911

❌ Size increased by 11.94KB from 61.75MB to 61.76MB (⬆️0.02%)

@github-actions

github-actions Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB +48.0 B (0.0%)
react-10k 5.7 MB 0
react-1k 827.2 KB 0
react-5k 2.7 MB 0
ui-components 4.8 MB 0
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

📌 Baseline Commit: e66c3dbdd9 | PR: #14143

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB +48.0 B (0.0%)
📄 JavaScript 1.7 MB 1.7 MB +48.0 B (0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 289.0 B 289.0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: popular-libs Bundle Diff

Generated by Rsdoctor GitHub Action

@CPunisher CPunisher changed the title chore: upgrade swc crates chore: upgrade swc_core from 66 to 67 May 26, 2026
@hardfist hardfist enabled auto-merge (squash) May 26, 2026 02:29
@hardfist hardfist merged commit c6fb557 into main May 26, 2026
37 checks passed
@hardfist hardfist deleted the cursor/upgrade-swc-crates-905d branch May 26, 2026 03:01
@JSerFeng JSerFeng mentioned this pull request May 27, 2026
Merged
JSerFeng added a commit that referenced this pull request May 27, 2026
@JSerFeng
Revert "chore: upgrade swc_core from 66 to 67" (#14168)
e428ea2 
Revert "chore: upgrade swc_core from 66 to 67 (#14135)"

This reverts commit c6fb557.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@CPunisher CPunisher CPunisher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hardfist @CPunisher @cursoragent