Revert "chore: upgrade swc_core from 66 to 67"#14168
Conversation
This reverts commit c6fb557.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54ca8b4d93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced SWC toolchain upgrade (swc_core 67.x) back to the prior pinned SWC versions to avoid breakage caused by changes in SWC helpers.
Changes:
- Downgrade
swc_corefrom67.0.1to66.0.2and align related SWC crate pins in the workspaceCargo.toml. - Regenerate
crates/rspack_workspace/src/generated.rsto reflect the restoredswc_coreversion. - Update
Cargo.lockto match the reverted dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rspack_workspace/src/generated.rs | Updates generated SWC version constant back to 66.0.2 to match workspace pins. |
| Cargo.toml | Reverts pinned SWC-related dependency versions (including swc_core) to the previous set. |
| Cargo.lock | Reflects the reverted SWC dependency resolution and checksums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Binary Size-limit
🎉 Size decreased by 11.94KB from 61.82MB to 61.80MB (⬇️0.02%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📦 Download Diff Report: popular-libs Bundle Diff Generated by Rsdoctor GitHub Action |
Merging this PR will improve performance by 6.87%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | rust@create_chunk_ids |
6.7 ms | 6.2 ms | +6.87% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing revert-14135-cursor/upgrade-swc-crates-905d (54ca8b4) with main (d05392f)
Footnotes
-
25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Reverts #14135 as there is a breaking of swc helpers