Conversation
6410c53 to
c7a835a
Compare
c7a835a to
4b749f2
Compare
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 romePath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 599.36KB from 48.70MB to 48.11MB (⬇️1.20%) |
Merging this PR will degrade performance by 21.67%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bundle@threejs-development |
649.5 ms | 829.3 ms | -21.67% |
Comparing chore/canary_for_pnp_global (b8e7a74) with main (35c2f4a)2
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
v1.x(a8d1edf) during the generation of this report, somain(35c2f4a) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8e7a74c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| regress = { version = "0.10.5", default-features = false, features = ["pattern"] } | ||
| ropey = { version = "1.6.1", default-features = false } | ||
| rspack_resolver = { features = ["package_json_raw_json_api", "yarn_pnp"], version = "0.6.6", default-features = false } | ||
| rspack_resolver = { features = ["package_json_raw_json_api", "yarn_pnp"], version = "0.7.0", default-features = false } |
There was a problem hiding this comment.
Keep cross-project Yarn PnP resolution working
In Yarn PnP setups that import code from another PnP-managed project, this version bump regresses module resolution. The upstream rspack_resolver v0.7.0 PR/release says it now assumes there is "one and only one .pnp.cjs file" and "no across-PnP-enabled project referencing", while Rspack still documents resolve.pnp as generic Yarn PnP support in website/docs/en/config/resolve.mdx:593-595. That means builds which cross into a second PnP project will start failing with module-not-found errors after this change, so we need either a compatibility layer/tests or to stay on 0.6.x.
Useful? React with 👍 / 👎.
Summary
backport of #13389
Related links
Checklist