feat(pnp)!: drop multi yarn pnp project resolving#13389
Conversation
ffba280 to
ee6f776
Compare
There was a problem hiding this comment.
Pull request overview
Updates Rspack’s Yarn PnP resolving behavior after upgrading to rspack_resolver@0.7.0, removing the custom pnpManifest-based multi-project resolving path and leaning on resolver defaults (including global cache support).
Changes:
- Bump
rspack_resolverfrom0.6.8to0.7.0. - Remove
pnp_manifest/pnpManifestsupport from core resolve options and some bindings. - Adjust resolver option conversion/merge logic accordingly.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/package.json | Package metadata change (currently introduces an invalid field). |
| crates/rspack_core/src/resolver/resolver_impl.rs | Drops pnp_manifest wiring when building rspack_resolver::ResolveOptions. |
| crates/rspack_core/src/options/resolve/mod.rs | Removes pnp_manifest from Resolve options. |
| crates/rspack_core/src/options/resolve/clever_merge.rs | Removes clever-merge handling for pnp_manifest. |
| crates/rspack_binding_api/src/rspack_resolver/mod.rs | Stops mapping pnp_manifest into resolver options. |
| crates/rspack_binding_api/src/options/raw_resolve.rs | Removes pnp_manifest from one raw options type but leaves a now-unused parsing path elsewhere. |
| crates/node_binding/napi-binding.d.ts | Removes pnpManifest from RawResolveOptions but leaves it in other exposed types. |
| Cargo.toml | Bumps rspack_resolver version; minor formatting change in lint config. |
| Cargo.lock | Lockfile updates for rspack_resolver@0.7.0 and new transitive deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Deploying rspack with
|
| Latest commit: |
c0b9fb3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://864ff715.rspack-v2.pages.dev |
| Branch Preview URL: | https://feat-pnp-global-cache-suppor.rspack-v2.pages.dev |
📦 Binary Size-limit
🎉 Size decreased by 18.63KB from 48.70MB to 48.68MB (⬇️0.04%) |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Summary
After upgrading to rspack-resolver@0.7.0, Rspack will change some features to PnP resolving
pnpManifestneededresolve.pnpManifestconfiguration removed, because Rspack resolver detects the manfiest file automaticly.Related links
Checklist