test: fix flaky watch-files-array e2e test case#5867
Merged
chenjiahan merged 1 commit intomainfrom Aug 18, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix the flaky watch-files-array e2e test case by refactoring the test to use DOM-based assertions instead of file system operations.
- Replace console.log with DOM element creation in the test application
- Remove custom test plugin and use Rsbuild's built-in define functionality for content injection
- Update test assertions to check DOM content changes instead of file existence
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/cases/cli/watch-files-array/src/index.js | Replace console.log with DOM element creation and content display |
| e2e/cases/cli/watch-files-array/rsbuild.config.ts | Remove custom plugin and use define configuration for content injection |
| e2e/cases/cli/watch-files-array/index.test.ts | Update test to use Playwright page assertions instead of file system checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the flaky watch-files-array e2e test case:
Related Links
Checklist