Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky watch files test cases by improving the test infrastructure and simplifying the test approach. The changes replace manual child process termination with a new close() helper function and enhance the runCli utility to support log assertions for more reliable testing.
Key changes:
- Enhanced
runCliutility with log capture and assertion capabilities - Simplified watch files test to use DOM assertions instead of file system checks
- Replaced manual
childProcess.kill()calls with a standardizedclose()method across all CLI tests
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/scripts/shared.ts | Enhanced runCli function with log capture, assertion methods, and standardized close functionality |
| e2e/cases/cli/watch-files/src/index.js | Changed from console logging to DOM manipulation for testable output |
| e2e/cases/cli/watch-files/rsbuild.config.ts | Simplified configuration by removing test plugin and using source.define for content injection |
| e2e/cases/cli/watch-files/index.test.ts | Rewrote test to use DOM assertions and new runCli utilities instead of file system checks |
| Multiple test files | Updated to use new close() method from enhanced runCli return value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Aug 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close()helperrunCliutility to support log assertionsChecklist