Skip to content

chore: remove node 16 compatibility patches and comments#5789

Merged
chenjiahan merged 1 commit intomainfrom
node_compat_patches_0807
Aug 7, 2025
Merged

chore: remove node 16 compatibility patches and comments#5789
chenjiahan merged 1 commit intomainfrom
node_compat_patches_0807

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Aug 7, 2025

Summary

This PR removes the custom patches for the 'open' and 'wsl-utils' dependencies, since compatibility with Node 16 is no longer required.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings August 7, 2025 09:07
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 7, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit d547ae3
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68946cd1a5a49a000839e779
😎 Deploy Preview https://deploy-preview-5789--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Node 16 compatibility patches and references as the project no longer requires compatibility with that version. The changes clean up legacy workarounds that were put in place to support Node 16.

  • Removes patches for the 'open' and 'wsl-utils' dependencies that were needed for Node 16 compatibility
  • Deletes patch files that contained workarounds for Node 16 import issues
  • Updates comments to reflect the new minimum Node version (18)

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml Removes patch entries for open@10.2.0 and wsl-utils@0.1.0
patches/wsl-utils@0.1.0.patch Deletes the entire patch file
patches/open@10.2.0.patch Deletes the entire patch file
packages/plugin-sass/prebundle.config.mjs Removes Node 16 compatibility comment
packages/plugin-less/prebundle.config.mjs Removes Node 16 compatibility comment
packages/core/src/helpers/index.ts Updates comment to reference Node 18 instead of Node 16
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@chenjiahan chenjiahan merged commit f33db4f into main Aug 7, 2025
13 checks passed
@chenjiahan chenjiahan deleted the node_compat_patches_0807 branch August 7, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants