fix: patch open to maintaining Node 16.10 compatibility#5570
Merged
chenjiahan merged 2 commits intomainfrom Jul 9, 2025
Merged
fix: patch open to maintaining Node 16.10 compatibility#5570chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the Node.js engine bump and applies a compatibility patch for Node 16.10 by normalizing workspace config and adding an open patch.
- Normalize
pnpm-workspace.yamlpackage entries, addhoistPattern, and include the newopen@10.1.2patch - Add
patches/open@10.1.2.patchto adjustfsimports for Node <16.17 - Downgrade core package’s Node engine requirement from
>=16.17.0to>=16.10.0
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Cleaned up package globs, moved hoistPattern, added open patch entry |
| patches/open@10.1.2.patch | Adjusted fs and fsConstants imports for broader Node support |
| packages/core/package.json | Lowered Node engine requirement to maintain 16.10 compatibility |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
pnpm-workspace.yaml:2
- The nested list entries (e.g.
- - 'website') duplicate the newly added single-dash entries. Remove the old nested syntax to avoid duplicate package definitions and YAML parsing issues.
- website
pnpm-workspace.yaml:15
- These patch entries now appear twice (once as list items with
-and once as direct mappings). Consolidate into a single consistent format to avoid confusion and potential parsing errors.
css-loader@7.1.2: patches/css-loader@7.1.2.patch
pnpm-workspace.yaml:20
- Consider quoting mapping keys and values containing
@and special characters (e.g.'open@10.1.2': 'patches/open@10.1.2.patch') to ensure robust YAML parsing.
open@10.1.2: patches/open@10.1.2.patch
Merged
2 tasks
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
#5566 (comment)
Checklist