Skip to content

fix: update Node.js engine requirement to >=16.17.0#5567

Merged
chenjiahan merged 1 commit intomainfrom
update_engine_0709
Jul 9, 2025
Merged

fix: update Node.js engine requirement to >=16.17.0#5567
chenjiahan merged 1 commit intomainfrom
update_engine_0709

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Update Node.js engine requirement to >=16.17.0 to allow using import { constants } from 'node:fs/promises';

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings July 9, 2025 02:26
@chenjiahan chenjiahan changed the title chore: update Node.js engine requirement to >=16.17.0 fix: update Node.js engine requirement to >=16.17.0 Jul 9, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 9, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5ddb658
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/686dd35f0f79ee0008d802dd
😎 Deploy Preview https://deploy-preview-5567--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the minimum required Node.js version to enable usage of the new node:fs/promises import.

  • Bumps the Node.js engine requirement from 16.10.0 to 16.17.0 in package.json
  • Aligns with the need to import constants from 'node:fs/promises'
Comments suppressed due to low confidence (1)

packages/core/package.json:104

  • [nitpick] Consider updating related documentation (e.g., README, CONTRIBUTING.md) and CI workflows to reflect the new Node.js engine requirement.
    "node": ">=16.17.0"

@chenjiahan chenjiahan merged commit 81e5bf1 into main Jul 9, 2025
14 checks passed
@chenjiahan chenjiahan deleted the update_engine_0709 branch July 9, 2025 03:43
chenjiahan added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Claimed Node.js >= 16.10.0 support missing in Rsbuild >= 1.4.2

2 participants