chore: fix no-unnecessary-boolean-literal-compare lint issues#5709
Merged
chenjiahan merged 1 commit intomainfrom Jul 30, 2025
Merged
chore: fix no-unnecessary-boolean-literal-compare lint issues#5709chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes TypeScript ESLint lint issues by removing the @typescript-eslint/no-unnecessary-boolean-literal-compare rule from the disabled rules list and updating code to eliminate unnecessary boolean literal comparisons throughout the codebase.
- Enables the
@typescript-eslint/no-unnecessary-boolean-literal-comparelint rule - Simplifies boolean comparisons by removing explicit
=== trueand=== falsechecks - Updates multiple files to use more concise boolean expressions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rslint.json | Removes the disabled lint rule to enable checking for unnecessary boolean literal comparisons |
| packages/core/src/server/helper.ts | Simplifies boolean comparison from === false to negation |
| packages/core/src/server/gzipMiddleware.ts | Removes explicit === false comparisons in filter and write operations |
| packages/core/src/plugins/output.ts | Simplifies === true comparison to direct boolean check |
| packages/core/src/plugins/minimize.ts | Removes unnecessary === true comparison in minify logic |
| packages/core/src/plugins/css.ts | Simplifies postcss plugin check by removing === true |
| packages/core/src/plugins/asset.ts | Changes === false to negation for emit check |
| packages/core/src/pluginManager.ts | Simplifies result comparison from === false to negation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all lint issues found by the
@typescript-eslint/no-unnecessary-boolean-literal-comparerules in Rslint.Related Links
Checklist