Skip to content

feat(create-rsbuild): support for project name with npm scope#2874

Merged
chenjiahan merged 1 commit intomainfrom
create_rsbuild_name_0711
Jul 11, 2024
Merged

feat(create-rsbuild): support for project name with npm scope#2874
chenjiahan merged 1 commit intomainfrom
create_rsbuild_name_0711

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Jul 11, 2024

Summary

Support for project name with npm scope:

/**
 * 1. Input: 'foo'
 *    Output: folder `<cwd>/foo`, `package.json#name` -> `foo`
 *
 * 2. Input: 'foo/bar'
 *    Output: folder -> `<cwd>/foo/bar` folder, `package.json#name` -> `bar`
 *
 * 3. Input: '@scope/foo'
 *    Output: folder -> `<cwd>/@scope/bar` folder, `package.json#name` -> `@scope/foo`
 *
 * 4. Input: './foo/bar'
 *    Output: folder -> `<cwd>/foo/bar` folder, `package.json#name` -> `bar`
 *
 * 5. Input: '/root/path/to/foo'
 *    Output: folder -> `'/root/path/to/foo'` folder, `package.json#name` -> `foo`
 */

TODO: add e2e case for create-rsbuild.

Related Links

web-infra-dev/rspack#7092

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 05ad366
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668f46a541b0db00082d204b
😎 Deploy Preview https://deploy-preview-2874--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 6f4bedb into main Jul 11, 2024
@chenjiahan chenjiahan deleted the create_rsbuild_name_0711 branch July 11, 2024 02:57
@9aoy 9aoy mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant