Skip to content

feat(create-rspack): update template package name#7092

Merged
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
liangchaofei:feat/custom-template-pkg-name
Jul 11, 2024
Merged

feat(create-rspack): update template package name#7092
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
liangchaofei:feat/custom-template-pkg-name

Conversation

@liangchaofei
Copy link
Copy Markdown
Contributor

@liangchaofei liangchaofei commented Jul 9, 2024

Automatically set the folder name entered by the user to the name of pkg.

Scenario: The package in the monorepo is usually the same as the entered folder name, so there is no need to modify it manually

将用户输入的文件夹名称自动渲染到pkg的name。

场景:monorepo中的包一般和输入的文件夹名称一样,就不需要手动修改了

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 9, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 9, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bd92c5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668f3753ea0f2a000881b57d
😎 Deploy Preview https://deploy-preview-7092--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@chenjiahan chenjiahan enabled auto-merge (squash) July 11, 2024 01:47
@chenjiahan chenjiahan changed the title feat: add custom template pkg name feat(create-rspack): add custom template pkg name Jul 11, 2024
@chenjiahan chenjiahan disabled auto-merge July 11, 2024 02:17
@chenjiahan chenjiahan merged commit 095f35c into web-infra-dev:main Jul 11, 2024
@chenjiahan chenjiahan changed the title feat(create-rspack): add custom template pkg name feat(create-rspack): update template package name Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants