Include deployment id in cacheHandlers keys#93453
Merged
Merged
Conversation
Contributor
Tests PassedCommit: c3228ce |
unstubbable
reviewed
May 4, 2026
unstubbable
left a comment
Contributor
There was a problem hiding this comment.
How was this ever working for dev? In that case,
buildId = "development"and so it always uses the same cache key
In dev we also have the hmrRefreshHash as part of the cache key.
| let key1 = await execute('value-1') | ||
| let key2 = await execute('value-2') | ||
| // Second run should not use the same key | ||
| expect(key1).not.toBe(key2) |
Contributor
There was a problem hiding this comment.
This assertion doesn't work in dev.
Member
Author
There was a problem hiding this comment.
It indeed fails because it reuses the cache. But is that intended behavior? What happens if you use a remote cache in dev?
Contributor
There was a problem hiding this comment.
'use cache: remote' doesn't have that problem because it also only uses the in-memory one with next dev (or next start). But a custom remote cache handler would indeed have the problem with Turbopack, because the hmrRefreshHash is just an incrementing number there and not a real hash. I guess another reason we need the implementation hash.
Member
Author
There was a problem hiding this comment.
So I'll just move this to test/production for now?
Contributor
There was a problem hiding this comment.
yeah, sounds good to me
unstubbable
approved these changes
May 4, 2026
Contributor
Stats from current PR🟢 2 improvements
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (16 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display app-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display 📎 Tarball URLCommit: c3228ce |
4 tasks
gnoff
added a commit
that referenced
this pull request
May 5, 2026
Backport #93453 to 16.2 How was this ever working for dev? In that case, `buildId = "development"` and so it always uses the same cache key Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this ever working for dev? In that case,
buildId = "development"and so it always uses the same cache key