Skip to content

[backport] Include deployment id in cacheHandlers keys#93471

Merged
gnoff merged 1 commit into
next-16-2from
jstory/deployment-id-fix-16-2
May 5, 2026
Merged

[backport] Include deployment id in cacheHandlers keys#93471
gnoff merged 1 commit into
next-16-2from
jstory/deployment-id-fix-16-2

Conversation

@gnoff

@gnoff gnoff commented May 4, 2026

Copy link
Copy Markdown
Contributor

Backport #93453 to 16.2

How was this ever working for dev? In that case, buildId = "development" and so it always uses the same cache key

How was this ever working for dev? In that case, `buildId =
"development"` and so it always uses the same cache key
@gnoff gnoff requested a review from unstubbable May 4, 2026 16:50
@unstubbable unstubbable changed the title Include deployment id in cacheHandlers keys [backport] Include deployment id in cacheHandlers keys May 4, 2026
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 592495d | About building and testing Next.js

pnpm test-dev test/e2e/rewrite-request-smuggling/rewrite-request-smuggling.test.ts (job)

  • rewrite-request-smuggling > does not smuggle a second request when using keep-alive only (DD)
Expand output

● rewrite-request-smuggling › does not smuggle a second request when using keep-alive only

expect(received).toContain(expected) // indexOf

Expected value: "DELETE /rewrites/poc"
Received array: []

  165 |
  166 |     await retry(async () => {
> 167 |       expect(backendRequests).toContain('DELETE /rewrites/poc')
      |                               ^
  168 |     })
  169 |     expect(backendRequests).not.toContain('GET /secret')
  170 |   })

  at toContain (e2e/rewrite-request-smuggling/rewrite-request-smuggling.test.ts:167:31)
  at fn (lib/next-test-utils.ts:861:20)
  at Object.<anonymous> (e2e/rewrite-request-smuggling/rewrite-request-smuggling.test.ts:166:5)

pnpm test-dev-turbo test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (turbopack) (job)

  • instant-nav-panel > should show loading skeleton during SPA navigation after clicking Start (DD)
Expand output

● instant-nav-panel › should show loading skeleton during SPA navigation after clicking Start

page.waitForSelector: Timeout 10ms exceeded.
Call log:
  - waiting for locator('[data-instant-nav-client]') to be visible
    - locator resolved to visible <button class="action-button" data-instant-nav-client="true">…</button>

  545 |
  546 |     return this.startChain(async () => {
> 547 |       const el = await page.waitForSelector(selector, {
      |                             ^
  548 |         timeout,
  549 |         state,
  550 |       })

  at waitForSelector (lib/browsers/playwright.ts:547:29)
  at Playwright._chain (lib/browsers/playwright.ts:677:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:658:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:546:17)
  at Playwright.waitForElementByCss (lib/browsers/playwright.ts:439:17)
  at elementByCssInstant (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:41:19)
  at Object.clickStartClientNav (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:149:11)
  at Proxy._chain (lib/browsers/playwright.ts:677:23)
  at Proxy._chain (lib/browsers/playwright.ts:653:17)
  at Proxy.continueChain (lib/browsers/playwright.ts:497:17)
  at click (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:41:68)
  at Object.clickStartClientNav (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:149:11)

@gnoff

gnoff commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

same CI jobs failing head without this commit so I'm going to merge

@gnoff gnoff merged commit 75d19ec into next-16-2 May 5, 2026
904 of 934 checks passed
@gnoff gnoff deleted the jstory/deployment-id-fix-16-2 branch May 5, 2026 21:54
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants