Skip to content

Fix fallback route params case in app-page handler#91737

Merged
ztanner merged 9 commits into
canaryfrom
ijjk/fix-vary-handling-for-encoded
Apr 6, 2026
Merged

Fix fallback route params case in app-page handler#91737
ztanner merged 9 commits into
canaryfrom
ijjk/fix-vary-handling-for-encoded

Conversation

@ijjk

@ijjk ijjk commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • add production-route-shape fixture coverage for /[teamSlug]/[project]/settings/domains
  • add revalidation helpers (API and server action) and browser controls used by the regression test
  • reproduce the failing production sequence by priming, revalidating, then loading a page with in-view next/link and navigating repeatedly

x-ref: #91627
x-ref: #91603

Testing

  • IS_WEBPACK_TEST=1 NEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=start pnpm testheadless test/e2e/app-dir/segment-cache/vary-params-base-dynamic/vary-params-base-dynamic.test.ts -t "production route shape" (passes)
  • NEXT_ENABLE_ADAPTER=1 pnpm test-deploy test/e2e/app-dir/segment-cache/vary-params-base-dynamic/vary-params-base-dynamic.test.ts -t "production route shape"
  • NEXT_ENABLE_ADAPTER=1 pnpm test-deploy test/e2e/app-dir/segment-cache/vary-params-base-dynamic/vary-params-base-dynamic.test.ts (fails in the two production-shape cases)

@nextjs-bot nextjs-bot added created-by: Next.js team PRs by the Next.js team. tests labels Mar 20, 2026
@nextjs-bot

nextjs-bot commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 438ms 440ms ✓ ▁▁▁▁▁
Cold (First Request) 1.106s 1.111s ✓ ▂▂▂▁▂
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 446ms 441ms ✓ ▁▁▁▁▁
Warm (First Request) 346ms 344ms ✓ ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 438ms 436ms ✓ ▃▁▁▁▁
Cold (First Request) 1.935s 1.952s ✓ ▄▂▁▁▂
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 437ms 436ms ✓ ▃▁▁▁▁
Warm (First Request) 1.946s 1.937s ✓ ▃▂▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.765s 3.786s ✓ ▁▁▁▁▁
Cached Build 3.828s 3.747s ✓ ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.430s 14.550s ✓ ▄▁▁▁▁
Cached Build 14.572s 14.663s ✓ ▄▁▁▁▁
node_modules Size 487 MB 487 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
02fkg8wfh0iju.js gzip 9.19 kB N/A -
050zwt5xh_0tx.js gzip 10.4 kB N/A -
06rvbj82bhyo0.js gzip 13 kB N/A -
087fzjd-gvlzv.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0hmlq-poen_t-.js gzip 157 B N/A -
0jinvht928g4f.js gzip 158 B N/A -
0kkw8tg-ocubb.js gzip 155 B N/A -
0l1lzugp0ksvm.js gzip 160 B N/A -
0ppxcl_z43mad.js gzip 8.52 kB N/A -
0ux97pue-yjq1.js gzip 156 B N/A -
0xaga-wfp9zue.js gzip 70.8 kB N/A -
17zjqcbzkqr3i.js gzip 168 B N/A -
19oha6-znmkcv.js gzip 8.55 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1izqq-lh0tfe7.js gzip 155 B N/A -
1pguylug0spyd.js gzip 65.7 kB N/A -
2_5rjb7lqxntf.js gzip 221 B 221 B ✓
219prxwxgaalc.js gzip 7.61 kB N/A -
26elcgxnn9zjd.js gzip 8.52 kB N/A -
2900hudr6gvm0.js gzip 2.28 kB N/A -
2dv-l_jnh4nll.js gzip 156 B N/A -
2e8e7a1ici2sg.js gzip 157 B N/A -
2e99sleuy25ku.js gzip 162 B N/A -
2lv2js3kmdeho.js gzip 8.48 kB N/A -
2rehygrd36hqv.js gzip 8.58 kB N/A -
2srwswih0m9_h.js gzip 13.3 kB N/A -
2ti84q_oc3z76.js gzip 153 B N/A -
3-p9p9mheqhzx.js gzip 8.55 kB N/A -
31030bryqpolg.js gzip 8.53 kB N/A -
31dx5nmrzzuy7.js gzip 225 B N/A -
3925v09gtu-5k.js gzip 49 kB N/A -
39x4zj5mjb4d_.js gzip 9.77 kB N/A -
3k-48b78ys_vy.js gzip 10.1 kB N/A -
3m7-5rfj0avoz.js gzip 12.9 kB N/A -
3uqce_6sa526g.js gzip 8.47 kB N/A -
3yurjqk-sjs3y.js gzip 1.46 kB N/A -
3zb6hoq6zjtmo.js gzip 156 B N/A -
40ybjx9c192n0.js gzip 13.8 kB N/A -
421vzwdt9j1b_.js gzip 5.62 kB N/A -
44ll2gsv38cvh.js gzip 157 B N/A -
turbopack-07..dmoz.js gzip 4.18 kB N/A -
turbopack-17..e6ja.js gzip 4.18 kB N/A -
turbopack-17..61z7.js gzip 4.16 kB N/A -
turbopack-1d..v4xm.js gzip 4.17 kB N/A -
turbopack-1p..59vf.js gzip 4.18 kB N/A -
turbopack-20..zwty.js gzip 4.17 kB N/A -
turbopack-2g..ta08.js gzip 4.19 kB N/A -
turbopack-2g..4wg7.js gzip 4.17 kB N/A -
turbopack-2i..lf-6.js gzip 4.18 kB N/A -
turbopack-2m..j0rz.js gzip 4.18 kB N/A -
turbopack-2p..n6lj.js gzip 4.18 kB N/A -
turbopack-3_..0fom.js gzip 4.18 kB N/A -
turbopack-37..v8dn.js gzip 4.18 kB N/A -
turbopack-3v..bsb8.js gzip 4.17 kB N/A -
03dgzoo-qf3sm.js gzip N/A 9.19 kB -
05tx5f25dlivn.js gzip N/A 8.53 kB -
0c7ez6p2qc57f.js gzip N/A 5.62 kB -
0duvj3qk5pvgn.js gzip N/A 13.8 kB -
0g2x7gvve9v2z.js gzip N/A 161 B -
0g9hwiffim6jx.js gzip N/A 155 B -
0m-34rm9w_wpm.js gzip N/A 7.6 kB -
0qnwuk92m8i7o.js gzip N/A 10.4 kB -
0r4wrn6n0ue2m.js gzip N/A 8.55 kB -
0rimus-isijl3.js gzip N/A 154 B -
0rp0fodtbt_6m.js gzip N/A 8.52 kB -
0sfck-km4dl1k.js gzip N/A 8.47 kB -
0wsggm2gh-ges.js gzip N/A 158 B -
0x0xuhmxzwkp8.js gzip N/A 8.47 kB -
1-wdvgxnzicj7.js gzip N/A 1.46 kB -
11u6nxujb2eg4.js gzip N/A 450 B -
1c5i51fexm_yj.js gzip N/A 65.7 kB -
1c9u8qch78g7q.js gzip N/A 70.8 kB -
1jv-o1_s-zmua.js gzip N/A 49 kB -
2k9ax08cjl2id.js gzip N/A 12.9 kB -
2lmcaq17omvnr.js gzip N/A 156 B -
2lms6k76q5-6m.js gzip N/A 13.3 kB -
2qx4twi9i3xus.js gzip N/A 2.28 kB -
2srnqic6tvxxd.js gzip N/A 8.52 kB -
2u1r9bcfx_7im.js gzip N/A 160 B -
2z0szsm15vh2b.js gzip N/A 155 B -
2zz_835zwahub.js gzip N/A 154 B -
307h6spznj8d7.js gzip N/A 156 B -
30l7m4nayp73a.js gzip N/A 8.55 kB -
38rr7d3kfutni.js gzip N/A 13 kB -
3ak3w7d8ttioq.js gzip N/A 158 B -
3b5uj2fcp7c5w.js gzip N/A 157 B -
3h_ecpiaatwgc.js gzip N/A 10.1 kB -
3ity0aahajapd.js gzip N/A 225 B -
3qw7x5va53jl3.js gzip N/A 169 B -
3wm9vhzaz51n2.js gzip N/A 156 B -
3wrhpuc-j1aw9.js gzip N/A 9.77 kB -
43mlw9dy_8f02.js gzip N/A 8.58 kB -
turbopack-0b..psap.js gzip N/A 4.18 kB -
turbopack-0h..bf9_.js gzip N/A 4.18 kB -
turbopack-11..bvy5.js gzip N/A 4.18 kB -
turbopack-1s..c1r4.js gzip N/A 4.18 kB -
turbopack-2a..32m2.js gzip N/A 4.18 kB -
turbopack-2d..xhfa.js gzip N/A 4.18 kB -
turbopack-2m..kbi3.js gzip N/A 4.18 kB -
turbopack-2s..zi-m.js gzip N/A 4.16 kB -
turbopack-2w..z0ye.js gzip N/A 4.18 kB -
turbopack-2z..txag.js gzip N/A 4.19 kB -
turbopack-3_..sqc_.js gzip N/A 4.17 kB -
turbopack-3-..cvdg.js gzip N/A 4.18 kB -
turbopack-3b..8bay.js gzip N/A 4.17 kB -
turbopack-42..06h6.js gzip N/A 4.18 kB -
Total 464 kB 464 kB ✅ -9 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 717 B 716 B ✓
Total 717 B 716 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 432 B 426 B 🟢 6 B (-1%)
Total 432 B 426 B ✅ -6 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 60.7 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 255 B ✓
main-HASH.js gzip 39.3 kB 39.2 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.8 kB -
9544-HASH.js gzip N/A 61.4 kB -
Total 235 kB 235 kB ⚠️ +649 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 126 kB ✓
page.js gzip 273 kB 273 kB ✓
Total 398 kB 398 kB ⚠️ +292 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 44 kB 44.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.6 kB 45.9 kB ⚠️ +262 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.37 MB 4.37 MB 🟢 4.9 kB (0%)
index.pack gzip 113 kB 115 kB 🔴 +2.39 kB (+2%)
index.pack.old gzip 114 kB 114 kB ✓
Total 4.6 MB 4.6 MB ✅ -2.82 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 342 kB 342 kB ✓
app-page-exp..prod.js gzip 189 kB 189 kB ✓
app-page-tur...dev.js gzip 341 kB 341 kB ✓
app-page-tur..prod.js gzip 189 kB 189 kB ✓
app-page-tur...dev.js gzip 338 kB 338 kB ✓
app-page-tur..prod.js gzip 187 kB 187 kB ✓
app-page.run...dev.js gzip 338 kB 338 kB ✓
app-page.run..prod.js gzip 187 kB 187 kB ✓
app-route-ex...dev.js gzip 76.6 kB 76.6 kB ✓
app-route-ex..prod.js gzip 52.2 kB 52.2 kB ✓
app-route-tu...dev.js gzip 76.6 kB 76.6 kB ✓
app-route-tu..prod.js gzip 52.2 kB 52.2 kB ✓
app-route-tu...dev.js gzip 76.2 kB 76.2 kB ✓
app-route-tu..prod.js gzip 52 kB 52 kB ✓
app-route.ru...dev.js gzip 76.2 kB 76.2 kB ✓
app-route.ru..prod.js gzip 52 kB 52 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.8 kB 43.8 kB ✓
pages-api-tu..prod.js gzip 33.4 kB 33.4 kB ✓
pages-api.ru...dev.js gzip 43.8 kB 43.8 kB ✓
pages-api.ru..prod.js gzip 33.4 kB 33.4 kB ✓
pages-turbo....dev.js gzip 53.2 kB 53.2 kB ✓
pages-turbo...prod.js gzip 39 kB 39 kB ✓
pages.runtim...dev.js gzip 53.2 kB 53.2 kB ✓
pages.runtim..prod.js gzip 39 kB 39 kB ✓
server.runti..prod.js gzip 62.8 kB 62.8 kB ✓
Total 3.03 MB 3.03 MB ✅ -2 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/06e1ddd676847a388d701c8389e8ae24465f66b5/next

@ijjk ijjk changed the title test: reproduce deploy vary-params revalidate regression Fix fallback route params case in app-page handler Mar 20, 2026
@ijjk ijjk marked this pull request as ready for review March 20, 2026 21:39
@vercel vercel deleted a comment from nextjs-bot Mar 23, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 24, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 24, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 24, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 24, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 24, 2026
@ijjk ijjk requested review from acdlite and ztanner March 24, 2026 23:35
@ijjk ijjk force-pushed the ijjk/fix-vary-handling-for-encoded branch from d877209 to 17c2584 Compare April 2, 2026 19:05
@vercel vercel deleted a comment from nextjs-bot Apr 3, 2026
@nextjs-bot

nextjs-bot commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

@ztanner ztanner force-pushed the ijjk/fix-vary-handling-for-encoded branch from b77e0fa to 06e1ddd Compare April 4, 2026 00:43
@ztanner ztanner merged commit 9931cc0 into canary Apr 6, 2026
308 of 312 checks passed
@ztanner ztanner deleted the ijjk/fix-vary-handling-for-encoded branch April 6, 2026 16:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ztanner ztanner ztanner approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk @nextjs-bot @ztanner