Handle encoded params further#91627
Merged
Merged
Conversation
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (25 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display app-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display server.runtime.prod.jsDiff too large to display 📎 Tarball URL |
ztanner
reviewed
Mar 19, 2026
| defaultRouteMatches: ParsedUrlQuery, | ||
| ignoreMissingOptional: boolean | ||
| ) { | ||
| const tryDecodeParamValue = (candidateValue: string) => |
Member
There was a problem hiding this comment.
Is this a problem for doubly encoded params since the route matcher does it once here? e.g. /acme/%2523hash currently matches as %23hash but this would turn it into #hash
Maybe we should compare against a decoded copy rather than mutate the param value returned to user code
Member
Author
There was a problem hiding this comment.
Addressed: placeholder checks now decode only into a temporary comparison value and no longer mutate the param returned to user code. This preserves /acme/%2523hash as %23hash for the param value. Added a unit regression for this case in packages/next/src/server/server-utils.test.ts.
|
|
||
| let normalizedCandidateValue = candidateValue | ||
| for (let i = 0; i < 3; i++) { | ||
| if (normalizedCandidateValue.includes(defaultValue)) { |
Member
There was a problem hiding this comment.
I'm worried about the substring matching here. For ex, a request to /acme/%255Bproject%255D-suffix for route /[team]/[project].
The route matcher already decodes once, so project becomes %5Bproject%5D-suffix.
Then this placeholder check decodes again, which turns it into [project]-suffix, and includes('[project]') returns true.
At that point we reject the param as if it were still the default placeholder, even though it's not.
It seems like this should only reject exact placeholder matches after normalization, not arbitrary values that contain the placeholder text.
Member
Author
There was a problem hiding this comment.
Good catch, fixed. Placeholder detection now uses exact match after normalization instead of substring matching. So /acme/%255Bproject%255D-suffix is no longer treated as a placeholder default. Added a regression test for this exact scenario in packages/next/src/server/server-utils.test.ts.
ztanner
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #91603 applying the encoding normalization further and narrows in a better regression test separate of root params and specific to vary params flag.