Support root level map keys in map sources#2047
Merged
Merged
Conversation
Contributor
Author
|
Related PR in |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It fixes a bug in
MapValueSourcewhere lookup doesn't work for keys directly in the first level (root) of the map.Which issue(s) this PR fixes:
Fixes #2037
Special notes for your reviewer:
The issue is related to this one I raised in
cli-altsrc: urfave/cli-altsrc#14I'll create a similar PR there as well.
Testing
I added a test case for this exact issue as well. It will fail without changes from the PR.
I also added another test case for the
map[string]anyspecial case that was in place in the code, to make sure that works to.