Support root level nested value lookups#16
Merged
Conversation
This was referenced Jan 29, 2025
dearchap
approved these changes
Jan 30, 2025
dearchap
left a comment
Contributor
There was a problem hiding this comment.
@lukasbindreiter Amazing work. Thanks for the PR. !!!
Contributor
Author
|
@dearchap CI was failing due to some unrelated test case - connecting to machines on a local network seems to be disabled on Github CI - I attempted to fix it by changing the expected error to a substring that covers both cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It fixes a bug in
NestedValwhere lookup doesn't work for keys directly in the first level (root) of the map.Which issue(s) this PR fixes:
Fixes #14
Special notes for your reviewer:
The issue is related to this one I raised in
cli: urfave/cli#2037I created a related PR there as well: urfave/cli#2047
The source code of
NestedVal, and even the tests seem to be a copy paste fromurfave/cliin this case.I kept it now like this as well - though there would be a possibility to remove that duplication by moving the
NestedValfunction tourfave/clidirectly, make it public and use it there insideMapSource.Lookupand then also incli-altsrc.If you prefer that approach I could update my PRs accordingly - though this would require the
urfave/clione to be merged and released before this PR can be updated to rely on it.Testing
I added a test case for this exact issue as well. It will fail without changes from the PR.
I also added another test case for the
map[string]anyspecial case that was in place in the code, to make sure that works to.