Skip to content

Fix postcss plugin options#38947

Merged
XhmikosR merged 1 commit intotwbs:mainfrom
o-alquimista:patch-1
Jul 24, 2023
Merged

Fix postcss plugin options#38947
XhmikosR merged 1 commit intotwbs:mainfrom
o-alquimista:patch-1

Conversation

@o-alquimista
Copy link
Copy Markdown
Contributor

@o-alquimista o-alquimista commented Jul 22, 2023 •
edited
Loading

Description

The current configuration doesn't work. If you check the output, the vendor prefixes aren't there.

I had to change the syntax a bit. It's a tiny fix.

You can see an example of the correct syntax here and here.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jul 23, 2023

What doesn't work? Because I do see the prefixes added in our dist files.

@o-alquimista
Copy link
Copy Markdown
Contributor Author

o-alquimista commented Jul 23, 2023

What doesn't work? Because I do see the prefixes added in our dist files.

This section is for users wishing to integrate Bootstrap in their Webpack configuration. It's not used to generate Bootstrap dist files.

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jul 23, 2023

So, you are saying this here https://github.com/twbs/examples/tree/main/webpack doesn't include the prefixes, right?

If so please make a PR against the examples repo first.

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jul 23, 2023

On a side note, I probably mixed up the syntax in twbs/examples@a242d6f

@o-alquimista o-alquimista mentioned this pull request Jul 23, 2023
Merged
@o-alquimista
Copy link
Copy Markdown
Contributor Author

o-alquimista commented Jul 23, 2023

So, you are saying this here https://github.com/twbs/examples/tree/main/webpack doesn't include the prefixes, right?

If so please make a PR against the examples repo first.

Yes. It's done.

@julien-deramond julien-deramond self-requested a review July 24, 2023 05:50
julien-deramond
julien-deramond approved these changes Jul 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on twbs/examples#297 (review) (verified in twbs/examples repo)

@XhmikosR XhmikosR merged commit 57ddb42 into twbs:main Jul 24, 2023
@o-alquimista o-alquimista deleted the patch-1 branch July 24, 2023 20:38
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@o-alquimista @romankupchak93
Fix postcss plugin options (twbs#38947)
d6d3061
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
@ilshaad ilshaad mentioned this pull request May 24, 2024
Open
@martinez-ml martinez-ml mentioned this pull request Sep 14, 2024
Merged
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

No one assigned

Labels

docs v5

Projects

No open projects
v5.3.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@o-alquimista @XhmikosR @julien-deramond