Conversation
10 tasks
julien-deramond
approved these changes
Jul 24, 2023
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Good catch @o-alquimista, I confirm the bug and the fix.
To test it for other reviewers, run the following on the main branch and on this branch:
npm run build
grep "moz-column" dist/main.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first opened this PR, but then I was instructed to open it against the examples repository.
The current configuration doesn't work. If you check the output, the vendor prefixes aren't there.
I had to change the syntax a bit. It's a tiny fix.
You can see an example of the correct syntax here and here.