Skip to content

fix(sdist): include docs/man/tox.1.rst#3890

Merged
rahuldevikar merged 1 commit intotox-dev:mainfrom
branchv:fix-sdist
Mar 19, 2026
Merged

fix(sdist): include docs/man/tox.1.rst#3890
rahuldevikar merged 1 commit intotox-dev:mainfrom
branchv:fix-sdist

Conversation

@branchv
Copy link
Copy Markdown
Contributor

@branchv branchv commented Mar 19, 2026

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Fixes #3889 (and #3885)

As described in the issues, the sdist is broken without docs/man/tox.1.rst. Also, I removed the --sdist and --wheel flags from uv build since by default, uv will build the sdist first and then the wheel from it, which would have caught this issue

@rahuldevikar rahuldevikar merged commit ef45bd8 into tox-dev:main Mar 19, 2026
27 checks passed
@branchv branchv deleted the fix-sdist branch March 19, 2026 18:37
gaborbernat pushed a commit to gaborbernat/tox that referenced this pull request Mar 30, 2026
<!-- Thank you for your contribution!

Please, make sure you address all the checklists (for details on how see
[development
documentation](http://tox.readthedocs.org/en/latest/development.html#development))!
-->

- [ ] ran the linter to address style issues (`tox -e fix`)
- [x] wrote descriptive pull request text
- [ ] ensured there are test(s) validating the fix
- [x] added news fragment in `docs/changelog` folder
- [ ] updated/extended the documentation

Fixes tox-dev#3889 (and tox-dev#3885)

As described in the issues, the sdist is broken without
`docs/man/tox.1.rst`. Also, I removed the `--sdist` and `--wheel` flags
from `uv build` since [by
default](https://docs.astral.sh/uv/reference/cli/#uv-build), uv will
build the sdist first and then the wheel from it, which would have
caught this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.50.1: wheel build from sdist fails due to missing docs/man/tox.1.rst

3 participants