Merged
Conversation
Fix up #335. `power_assert` is required in util/backtracefilter.rb too, that is required from assertions.rb, and raises `SyntaxError` twice. As the latter file always requires the former file, the second `require` doesn't make sense.
Member
|
Should we release this too? |
Member
Author
Yes, sorry for repeating it. |
Member
|
No problem. |
nobu
added a commit
to nobu/timeout
that referenced
this pull request
Nov 26, 2025
This reverts commit 983cbf6, that is fixed by test-unit/test-unit#335 and test-unit/test-unit#337.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix up #335.
power_assertis required in util/backtracefilter.rb too, that is required from assertions.rb, and raisesSyntaxErrortwice.As the latter file always requires the former file, the second
requiredoesn't make sense.