Squash syntax warnings as well as syntax errors #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-unit always tries to load power_assert, but recent power_assert uses syntax available since ruby 3.1. Even when test-unit squashes SyntaxError, warnings for experimental syntax or unsupported syntax are emitted before rescued, and can cause problems sometimes.
Member
|
Should we release a new version with this? |
Member
Author
Yes, ruby/cgi fails because of these warnings: https://github.com/ruby/cgi/actions |
Member
|
Released. |
Member
Author
|
Thanks! |
nobu
added a commit
that referenced
this pull request
Nov 25, 2025
Fix up #335. `power_assert` is required in util/backtracefilter.rb too, that is required from assertions.rb, and raises `SyntaxError` twice. As the latter file always requires the former file, the second `require` doesn't make sense.
kou
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fix up #335. `power_assert` is required in util/backtracefilter.rb too, that is required from assertions.rb, and raises `SyntaxError` twice. As the latter file always requires the former file, the second `require` doesn't make sense.
nobu
added a commit
to nobu/timeout
that referenced
this pull request
Nov 26, 2025
This reverts commit 983cbf6, that is fixed by test-unit/test-unit#335 and test-unit/test-unit#337.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-unit always tries to load power_assert, but recent power_assert uses syntax available since ruby 3.1.
Even when test-unit squashes SyntaxError, warnings for experimental syntax or unsupported syntax are emitted before rescued, and can cause problems sometimes.