Add Intl.{Duration,DateTime,RelativeTime}Format option keys to domprops#1680
Merged
fabiosantoscode merged 1 commit intoMay 7, 2026
Merged
Conversation
…mat) to domprops. Closes terser#1679
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1679.
Adds the field/option names used by
Intl.DurationFormat,Intl.DateTimeFormat, andIntl.RelativeTimeFormattotools/domprops.js, somangle.propertiesdoesn't silently break code like:Sibling change to #1652, which added
Temporal,Duration, andDurationFormatclass names but not their record/option fields. The singular forms (year,month,day,hour,minute,second) also cover Temporal record fields.29 entries total, alphabetically merged into the existing list:
years,months,weeks,days,hours,minutes,seconds,milliseconds,microseconds,nanosecondsweekday,era,year,month,day,dayPeriod,hour,minute,second,fractionalSecondDigits,hour12,hourCycle,dateStyle,timeStyle,timeZone,timeZoneName,calendar,numberingSystemnumericnpm test(246 passing),npm run lint, andnpm run ls-lintall pass.