add "observedAttributes" to domprops list#1652
Merged
Merged
Conversation
Contributor
Author
|
@fabiosantoscode Can this be merged soon? It’s so simple that it won’t require much review. |
Collaborator
|
Hey! I saw this but I put it off because of the other APIs you mention (Temporal, etc). But it's true, it's a small PR. |
fabiosantoscode
added a commit
that referenced
this pull request
Jan 15, 2026
fabiosantoscode
added a commit
that referenced
this pull request
Jan 15, 2026
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
Among other custom element-related DOM properties, like
connectedCallback,disconnectedCallback,adoptedCallback,attributeChangedCallback, etc. there's also a static property called observedAttributes.I realized this property is missing when mangling a Lit web component app. I added it to save anyone doing the same thing some trouble.
Additional
There are some other missing properties. Some of these released in stable Chrome on Feb 4, 2025, so it may be time to add them here as well.