Skip to content

refactor(oas31): use system.fn as source of truth for all components#9153

Merged
char0n merged 2 commits intoswagger-api:masterfrom
pplr:refactor/oas31-system-fn
Nov 13, 2023
Merged

refactor(oas31): use system.fn as source of truth for all components#9153
char0n merged 2 commits intoswagger-api:masterfrom
pplr:refactor/oas31-system-fn

Conversation

@pplr
Copy link
Copy Markdown
Contributor

@pplr pplr commented Aug 21, 2023

Changes introduced by the commit b017858 on the Models wrapper should also apply to the Model wrapper.

Motivation and Context

The isExpandable and getProperties injected in the schema context are not the ones from the system.fn context. Overriding these functions in a plugin has a non consistent effect. The overrided functions are used on the Models compoments tree, but not on the Model component.

How Has This Been Tested?

No specific test as been added because this is a refactoring. I executed npm run test.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@pplr pplr force-pushed the refactor/oas31-system-fn branch 2 times, most recently from 7f5bfc0 to f2eac81 Compare August 25, 2023 06:56
@pplr pplr force-pushed the refactor/oas31-system-fn branch from f2eac81 to 4846127 Compare September 1, 2023 12:05
@char0n char0n self-requested a review November 13, 2023 12:46
@char0n char0n self-assigned this Nov 13, 2023
Copy link
Copy Markdown
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for change! At this point it's more a fix than a refactor.

@char0n char0n merged commit 20c2c74 into swagger-api:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants