refactor(oas31): use system.fn as source of truth for all components#9153
Merged
char0n merged 2 commits intoswagger-api:masterfrom Nov 13, 2023
Merged
refactor(oas31): use system.fn as source of truth for all components#9153char0n merged 2 commits intoswagger-api:masterfrom
char0n merged 2 commits intoswagger-api:masterfrom
Conversation
7f5bfc0 to
f2eac81
Compare
f2eac81 to
4846127
Compare
char0n
approved these changes
Nov 13, 2023
Contributor
char0n
left a comment
There was a problem hiding this comment.
LGTM. Thanks for change! At this point it's more a fix than a refactor.
delendik-testops
pushed a commit
to ModiusOpenData/swagger-ui
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced by the commit b017858 on the
Modelswrapper should also apply to theModelwrapper.Motivation and Context
The
isExpandableandgetPropertiesinjected in the schema context are not the ones from thesystem.fncontext. Overriding these functions in a plugin has a non consistent effect. The overrided functions are used on theModelscompoments tree, but not on theModelcomponent.How Has This Been Tested?
No specific test as been added because this is a refactoring. I executed
npm run test.Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests